Visitar URL original
USWDS - update data prop for consistency by ethangardner · Pull Request #6688 · uswds/uswds · GitHub
Skip to content

USWDS - update data prop for consistency #6688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ethangardner merged 4 commits into from
Jun 5, 2026
Merged

USWDS - update data prop for consistency #6688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35213be
update data prop and remove aria
ethangardner Jun 2, 2026
da2f779
add label to svg with role
ethangardner Jun 2, 2026
7a4ac2b
Merge branch 'develop' into feature/6687-data-prop-update
annepetersen Jun 4, 2026
92eede3
Merge branch 'develop' into feature/6687-data-prop-update
ethangardner Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/usa-in-page-navigation/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ const shouldRenderInPageNav = (
const createInPageNav = (el) => {
const inPageNavEl = el;

if (inPageNavEl.dataset.created) return;
if (inPageNavEl.dataset.enhanced) return;

const inPageNavTitleText = Sanitizer.escapeHTML`${
inPageNavEl.dataset.titleText || IN_PAGE_NAV_TITLE_TEXT
Expand Down Expand Up @@ -368,7 +368,7 @@ const createInPageNav = (el) => {
observeSections.observe(tag);
});

inPageNavEl.dataset.created = "true";
inPageNavEl.dataset.enhanced = "true";
};

/**
Expand Down
4 changes: 2 additions & 2 deletions packages/usa-tooltip/src/test/test-patterns/test-usa-tooltip-non-button.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
</svg>
</div>
<div class="margin-4">
<a href="agency.gov" class="usa-tooltip" title="Link to agency.gov" aria-label="Link to agency.gov">Link</a>
<a href="agency.gov" class="usa-tooltip" title="Link to agency.gov">Link</a>
</div>
<div class="margin-4">
<span class="usa-tooltip" title="Span tooltip" aria-label="Span tooltip">Span text</span>
<span class="usa-tooltip" title="Span tooltip">Span text</span>
</div>