Visitar URL original
USWDS-Site - Changelog: Allow banner to init without accordion requirement by mejiaj · Pull Request #2301 · uswds/uswds-site · GitHub
Skip to content

USWDS-Site - Changelog: Allow banner to init without accordion requirement - #2301

Merged
amyleadem merged 6 commits into
release-3.7.0from
jm-feature-banner-init
Oct 31, 2023
Merged

amyleadem merged 6 commits into
release-3.7.0from
jm-feature-banner-init

Conversation

@mejiaj

@mejiaj mejiaj commented Oct 11, 2023 •

Copy link
Copy Markdown
Contributor

Summary

Added changelog entry to banner.

Related issue

Changelog for uswds/uswds#5551

Preview link

Preview link: TK

Testing and review

  • Zero regressions in Banner & accordion (especially event conflicts).
  • Changelog entry exists for this feature.
  • Zero webdev console errors.

Todo

  • Update changelog date & USWDS version.
  • Restore USWDS version in package.json.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

Update date & versionUswds fields.

Comment thread package.json

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

Restore USWDS version.

@amyleadem
amyleadem changed the base branch from main to release-3.7.0 October 27, 2023 21:01
Comment thread _data/changelogs/component-banner.yml Resolved

@amyleadem amyleadem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyleadem
amyleadem marked this pull request as ready for review October 31, 2023 21:19
@amyleadem
amyleadem merged commit 94a434c into release-3.7.0 Oct 31, 2023
@mejiaj
mejiaj deleted the jm-feature-banner-init branch November 8, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants