Visitar URL original
USWDS-Site: Documentation updates for release 3.7.0 by amyleadem · Pull Request #2332 · uswds/uswds-site · GitHub
Skip to content

USWDS-Site: Documentation updates for release 3.7.0 - #2332

Merged
thisisdano merged 75 commits into
mainfrom
release-3.7.0
Nov 9, 2023
Merged

USWDS-Site: Documentation updates for release 3.7.0#2332
thisisdano merged 75 commits into
mainfrom
release-3.7.0

Conversation

@amyleadem

@amyleadem amyleadem commented Oct 31, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Changelogs for all updates in the USWDS 3.7.0 release.

Preview links

mahoneycm and others added 30 commits June 1, 2023 16:43
@mahoneycm
Create modal changelog item
3532aa2
mahoneycm @amyleadem
Follow new changelog version pattern
bf386da 
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
@mahoneycm
Update change log summary
073ac62
@mahoneycm
Add changelog entry
a78f1a4
@mahoneycm
Make changelog past tense
d3292e0
@mahoneycm
Reword changelog
8be9a4e
@mahoneycm
Create changelog
8ca5033
Amy Leadem
Add entry for #5491
521629e
@mahoneycm
Improve changelog with additional context
d143905
mahoneycm @amyleadem
Restructure summaryAdditional
636c54e 
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
@mahoneycm
Remove unintentional external link change
a8513ac
@mahoneycm
Update changelog entry to include markup instructions
393af13
@mahoneycm
Add affectsMarkup: true to changelog
b515072
James Mejia
Test banner init feature branch
25f28ec
James Mejia
Add changelog entry
eea5416
@mahoneycm
Update guidance to reflect new attributes
9f28c1b
@mahoneycm
Add changelog
4d306fa
Amy Leadem
Create entry for #5572
b75b525
Amy Leadem
Add entry for #5571
5fcd938
@mahoneycm
Update attribute names
cecb591
Amy Leadem
Update 5572 --> 5582
8183278
Amy Leadem
Create entry for #5550
1e6137a
Amy Leadem
Update copy for 5550
0bcfdcf
Amy Leadem
Create entry for 5542
7a4118d
Amy Leadem
Edit summary copy on #5542
9a50157
Amy Leadem
Update #5491
a384309
@mahoneycm
Create changelog
b1e64fe
Amy Leadem
Update summary on 5550
b7c83f8
@thisisdano
Add X icon changelog
3657ecc
@thisisdano
Add assets label
992d501
@amyleadem
amyleadem marked this pull request as ready for review November 6, 2023 17:43
Amy Leadem and others added 2 commits November 6, 2023 10:51
@amyleadem amyleadem added this to the uswds 3.7.0 milestone Nov 6, 2023
@amyleadem amyleadem self-assigned this Nov 6, 2023
amyleadem
amyleadem commented Nov 6, 2023
View reviewed changes
Comment thread .nvmrc
@amyleadem

amyleadem commented Nov 6, 2023

Copy link
Copy Markdown
Contributor Author

@thisisdano I confirmed the following items:

  • Confirmed that all 3.7.0 items have related documentation updates
  • Confirmed that changelogs are written in past tense and have periods.
  • Confirmed changelog information is accurate.
  • Confirmed that the changelog item tags are appropriate
  • Confirmed that changelog dates and version numbers have been updated
    • Not done yet
  • Confirmed that all references to node version 16.18.0 have been updated to 20.9.0
    • Added a comment about a possible edit to the README

mahoneycm
mahoneycm suggested changes Nov 6, 2023
View reviewed changes

@mahoneycm mahoneycm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelogs look good to me! I think we should update the Node version in the README then this should get the green stamp 👍

  • Changelogs are accurate
  • PR numbers are correct
  • No spelling or grammar issues!

Comment thread .nvmrc
mejiaj
mejiaj approved these changes Nov 8, 2023
View reviewed changes

@mejiaj mejiaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good and all changes seem to be captured.

@mejiaj
mejiaj requested a review from mahoneycm November 8, 2023 20:17
amyleadem
amyleadem commented Nov 9, 2023
View reviewed changes
Comment thread _data/changelogs/component-card.yml Outdated
type: component
changelogURL:
items:
- date: 2023-11-9

@amyleadem amyleadem Nov 9, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other release dates on the 9th of the month have a leading zero

Suggested change
- date: 2023-11-9
- date: 2023-11-09

@thisisdano thisisdano Nov 9, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@thisisdano
thisisdano merged commit 3111955 into main Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thisisdano thisisdano Awaiting requested review from thisisdano
2 more reviewers
@mejiaj mejiaj mejiaj approved these changes
@mahoneycm mahoneycm mahoneycm approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@amyleadem amyleadem

Labels

None yet

Projects

No open projects
USWDS Core Project Data
Archived in project

Milestone

uswds 3.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@amyleadem @mejiaj @thisisdano @mahoneycm