Visitar URL original
Form component: Updated Disabled States guidance by finekatie · Pull Request #2776 · uswds/uswds-site · GitHub
Skip to content

Form component: Updated Disabled States guidance - #2776

Merged
annepetersen merged 15 commits into
mainfrom
kf-disabledstates-formcomponent
Oct 4, 2024
Merged

Form component: Updated Disabled States guidance#2776
annepetersen merged 15 commits into
mainfrom
kf-disabledstates-formcomponent

Conversation

@finekatie

@finekatie finekatie commented Aug 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Add Disabled states guidance section with new guidance.

Related issue

Affects #2246

Does not close it as there are two other PRs for other pages.

Related to #2744

Preview link:

Preview link: Form component

Form template page

Problem statement

Current page does not have guidance for disabled states.
Research and discussion among USWDS team members have resulted in a solution

Solution

Will be adding accessibility guidance to this page as part of a Phase 1 of Disabled States work.

Testing and review

  • Make sure copy is in the correct place
  • Make sure copy has no errors or typos
  • Make sure links work

!ALERT!

  • We'll need to update the changelog

@finekatie
Form component: Updated Disabled States guidance
f6a353d 
Adding a section to guidance for disabled states.
This was referenced Aug 11, 2024
Closed
Closed
@finekatie finekatie self-assigned this Aug 11, 2024
@finekatie finekatie added Affects: Accessibility 🟡 Affects access for disabled users or assistive tech. Record the barrier; not a severity score. Affects: Content Relates to content Affects: Guidance Relates to guidance Affects: Usability Relates to the usability of our code or components labels Aug 11, 2024
@finekatie finekatie mentioned this pull request Aug 11, 2024
Merged
@finekatie
finekatie requested a review from amyleadem August 11, 2024 22:32
jaclinec
jaclinec suggested changes Aug 12, 2024
View reviewed changes

@jaclinec jaclinec left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great except one tiny thing. For the sentence "If you must use disabled states, follow best practices." The "must" should be italicized. Once that is changed it is good to go!

@finekatie

finekatie commented Aug 12, 2024

Copy link
Copy Markdown
Contributor Author

Everything looks great except one tiny thing. For the sentence "If you must use disabled states, follow best practices." The "must" should be italicized. Once that is changed it is good to go!

All set!

@finekatie
finekatie requested a review from jaclinec August 12, 2024 21:08
@finekatie
Adding changelog to page.
e4e53df 
Form component page needs changelog update with this section addition. Just added it.
@finekatie

finekatie commented Aug 12, 2024

Copy link
Copy Markdown
Contributor Author

Added changelog but realized this is also in use on the Form templates page and this update isn't the same as what will be seen on form templates page. Will need help resolving.

@finekatie

finekatie commented Aug 22, 2024

Copy link
Copy Markdown
Contributor Author

Closed #2775 in favor of this. Copy changes to clarify are coming and will submit for FFR when complete.

mahoneycm
mahoneycm reviewed Aug 22, 2024
View reviewed changes
Comment thread _includes/forms-guidance.html Outdated
jaclinec
jaclinec approved these changes Aug 23, 2024
View reviewed changes

@jaclinec jaclinec left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@finekatie Charlie Mahoney
Update _includes/forms-guidance.html
92240e7 
Co-authored-by: Charlie Mahoney <charlie.mahoney@bixal.com>
@finekatie
finekatie requested review from mahoneycm and thisisdano and removed request for amycole501 and amyleadem August 23, 2024 21:50
@finekatie

finekatie commented Aug 23, 2024

Copy link
Copy Markdown
Contributor Author

Hey @mahoneycm , I merged your changes and it's ready for Dan to review. Take a look if you want to confirm :)
Thank you so much for all the help!

mahoneycm
mahoneycm approved these changes Aug 26, 2024
View reviewed changes

@mahoneycm mahoneycm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@finekatie lgtm! I also added a preview link to the form template page since this page is updated with the same content 👍

thisisdano
thisisdano suggested changes Sep 9, 2024
View reviewed changes

@thisisdano thisisdano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like the changelog to be a bit more specific

Comment thread _data/changelogs/component-form.yml Outdated
Comment thread _includes/forms-guidance.html Outdated
Comment thread _data/changelogs/component-form.yml Outdated
Comment thread _data/changelogs/component-form.yml Outdated
@thisisdano
thisisdano requested a review from amyleadem September 9, 2024 04:33
@thisisdano

thisisdano commented Sep 9, 2024

Copy link
Copy Markdown
Contributor

I also added @amyleadem as a reviewer for another editorial eye.

amyleadem and others added 2 commits September 12, 2024 14:57
amyleadem
Merge branch 'main' of https://github.com/uswds/uswds-site into kf-di…
4b3c3b7 
…sabledstates-formcomponent
@amyleadem @thisisdano
Tweak copy
98f7a24 
Co-authored-by: Dan O. Williams <11464021+thisisdano@users.noreply.github.com>
amyleadem
amyleadem suggested changes Sep 12, 2024
View reviewed changes

@amyleadem amyleadem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added a couple of small suggestions below. Let me know if you have any questions.

Comment thread _data/changelogs/component-form.yml Outdated
Comment thread _data/changelogs/component-form.yml Outdated
Comment thread _includes/forms-guidance.html Outdated
Comment thread _data/changelogs/component-form.yml Outdated
amyleadem and others added 2 commits September 12, 2024 15:36
@amyleadem
Update repo for 2776
25735d2
@finekatie @amyleadem
Apply suggestions from code review
3066645 
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
amyleadem
amyleadem approved these changes Sep 16, 2024
View reviewed changes

@amyleadem amyleadem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Important

We need to update the changelog date before merge.

@annepetersen
Update component-form.yml
34b1eb7 
added changelog date
@annepetersen

annepetersen commented Sep 27, 2024

Copy link
Copy Markdown
Contributor

Was hoping to update the changelog and merge, but this has some tests failing, so that date addition might be premature. Intending to look again on Monday.

@annepetersen annepetersen self-assigned this Sep 27, 2024
@annepetersen
annepetersen self-requested a review September 27, 2024 21:00
@annepetersen

annepetersen commented Oct 1, 2024

Copy link
Copy Markdown
Contributor

@amyleadem, could you look at the failing tests here?

annepetersen
annepetersen approved these changes Oct 4, 2024
View reviewed changes

@annepetersen annepetersen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annepetersen
annepetersen merged commit e0a8d87 into main Oct 4, 2024
@annepetersen
annepetersen deleted the kf-disabledstates-formcomponent branch October 4, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

7 more reviewers
@amycole501 amycole501 amycole501 approved these changes
@thisisdano thisisdano thisisdano requested changes
@annepetersen annepetersen annepetersen approved these changes
@mahoneycm mahoneycm mahoneycm approved these changes
@amyleadem amyleadem amyleadem approved these changes
@jaclinec jaclinec jaclinec approved these changes
@alex-hull alex-hull alex-hull approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@annepetersen annepetersen

@finekatie finekatie

Labels

Affects: Accessibility 🟡 Affects access for disabled users or assistive tech. Record the barrier; not a severity score. Affects: Content Relates to content Affects: Guidance Relates to guidance Affects: Usability Relates to the usability of our code or components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@finekatie @thisisdano @annepetersen @mahoneycm @amyleadem @jaclinec @amycole501 @alex-hull