Visitar URL original
feat(extensions): add dashMode and whole-path justification by chrisgervang · Pull Request #10582 · visgl/deck.gl · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
137 commits
Select commit Hold shift + click to select a range
ee77305
test(extensions): add dash rendering baseline matrix for PathStyleExt…
claude Aug 2, 2026
ed5d48c
test: recreate dash layers when dashMode changes
chrisgervang Aug 22, 2026
75c62a3
test(extensions): add default dash path variants
chrisgervang Aug 22, 2026
4a870d7
test(extensions): isolate 3D dash arclength
chrisgervang Aug 22, 2026
18fa198
test(extensions): cover pitched rounded billboard dashes
chrisgervang Aug 23, 2026
0685753
test(extensions): separate path variant fixtures
chrisgervang Aug 24, 2026
5077f74
test(extensions): capture continuous offset dash baseline
chrisgervang Aug 26, 2026
107d31f
fix(extensions): make dashes match between billboard and flat paths
claude Aug 2, 2026
1122829
fix(layers): preserve billboard dash phase through 3D joins
chrisgervang Aug 23, 2026
3a72563
test(extensions): verify continuous offset dash phase
chrisgervang Aug 26, 2026
28811b2
feat(extensions): prefilter dash coverage instead of a binary discard
claude Aug 2, 2026
e392cc7
fix(extensions): preserve rounded dash body coverage
chrisgervang Aug 22, 2026
a5d8f0e
fix(extensions): define rounded dash derivatives
chrisgervang Aug 22, 2026
7c17983
fix(extensions): bound justified dash coverage
chrisgervang Aug 22, 2026
5472815
test(extensions): refresh pitched billboard coverage golden
chrisgervang Aug 23, 2026
62bd027
fix(extensions): defer dash discard until after derivatives
chrisgervang Aug 24, 2026
6906ad3
test(extensions): release dash picking WebGL context
chrisgervang Aug 24, 2026
a9872d3
feat(extensions): add dashMode to decouple dashes from tessellation
claude Aug 2, 2026
0179d39
test(extensions): compare dash modes on path variants
chrisgervang Aug 22, 2026
776eacf
test(extensions): refresh separated dash mode variants
chrisgervang Aug 24, 2026
f6ee3f2
fix(extensions): let dashMode 'segment' enable dashing
claude Aug 8, 2026
ee4ac78
test(extensions): compare dash mode combinations
chrisgervang Aug 26, 2026
0315f2f
docs(extensions): defer dashMode guide to docs layer
chrisgervang Aug 27, 2026
02744cd
fix(extensions): omit dash uniforms for offset-only path styles
chrisgervang Aug 29, 2026
1c363c0
Merge prerequisite offset-only uniform fix into PathStyle dash baseline
chrisgervang Aug 29, 2026
ac8c5f1
test(bench): establish PathStyleExtension baseline costs
chrisgervang Aug 29, 2026
0629d30
Merge updated PathStyle dash baseline into alignment fixes
chrisgervang Aug 29, 2026
41ae22e
fix(path-layer): compile dash arclength only when enabled
chrisgervang Aug 29, 2026
22b3635
fix(extensions): derive dash phase from rendered path geometry
chrisgervang Aug 29, 2026
47f5ece
Merge updated PathStyle dash alignment fixes into analytic coverage
chrisgervang Aug 29, 2026
5740e07
fix(extensions): make analytic dash coverage derivative-safe
chrisgervang Aug 29, 2026
c4a9e01
fix(extensions): preserve geometric rounded-cap coverage below a pixel
chrisgervang Aug 29, 2026
19caf09
Merge updated analytic dash coverage into path controls
chrisgervang Aug 29, 2026
6ec8a3a
fix(extensions): preserve PathStyleExtension API compatibility
chrisgervang Aug 29, 2026
e805ce8
fix(extensions): synchronize live PathStyle option changes
chrisgervang Aug 29, 2026
8d17232
fix(extensions): bound whole-path dash justification
chrisgervang Aug 29, 2026
d36348d
docs(rfc): consolidate stable PathStyle dash controls
chrisgervang Aug 29, 2026
fdd0d15
test(extensions): clarify PathStyle callback names
chrisgervang Aug 29, 2026
c296cb4
Merge prerequisite review fix into PathStyle dash baseline
chrisgervang Aug 29, 2026
f7d6c14
Merge baseline review fix into PathStyle dash alignment
chrisgervang Aug 29, 2026
0d7306d
fix(extensions): align dash phase with auto-offset projection
chrisgervang Aug 29, 2026
bb1bf47
fix(extensions): complete auto-offset phase tracking
chrisgervang Aug 29, 2026
d5e0119
fix(core): make attribute buffer cleanup idempotent
chrisgervang Aug 29, 2026
45d986d
Merge attribute cleanup prerequisite into PathStyle offset fix
chrisgervang Aug 29, 2026
04a7dc5
Merge prerequisite review fixes into PathStyle dash baseline
chrisgervang Aug 29, 2026
ead1078
Merge baseline review fixes into PathStyle dash alignment
chrisgervang Aug 29, 2026
9bac79e
Merge reviewed dash phase fixes into analytic coverage
chrisgervang Aug 29, 2026
a45b18a
Merge reviewed analytic coverage parent into dash controls
chrisgervang Aug 29, 2026
3b6a81d
fix(path-layer): avoid retessellation at projection boundaries
chrisgervang Aug 29, 2026
504df65
Merge projection-boundary fix into analytic dash coverage
chrisgervang Aug 29, 2026
5ebfe59
Merge projection-boundary fix into PathStyle controls
chrisgervang Aug 29, 2026
b8ba16b
fix(path-layer): intersect rounded analytic coverage
chrisgervang Aug 29, 2026
fc836ab
Merge rounded offset coverage fix into PathStyle controls
chrisgervang Aug 29, 2026
6affdb4
test(bench): provide viewport for PathStyle phase metrics
chrisgervang Aug 29, 2026
689e3c7
Merge PathStyle benchmark fixture fix into analytic coverage
chrisgervang Aug 29, 2026
bd5f519
Merge PathStyle benchmark fixture fix into path controls
chrisgervang Aug 29, 2026
4105a52
fix(extensions): avoid double-filtering rounded dash shoulders
chrisgervang Aug 29, 2026
c02a48c
Merge branch 'claude/deck-gl-path-dashing-2jnq8i-3' into claude/deck-…
chrisgervang Aug 30, 2026
3fec268
Merge remote-tracking branch 'origin/master' into codex/path-style-of…
chrisgervang Aug 30, 2026
48bff3a
Merge branch 'codex/path-style-offset-uniforms' into claude/deck-gl-p…
chrisgervang Aug 30, 2026
0b4a96a
Merge branch 'claude/deck-gl-path-dashing-2jnq8i' into claude/deck-gl…
chrisgervang Aug 30, 2026
aad189d
Merge branch 'claude/deck-gl-path-dashing-2jnq8i-2' into claude/deck-…
chrisgervang Aug 30, 2026
cc42a0d
Merge branch 'claude/deck-gl-path-dashing-2jnq8i-3' into claude/deck-…
chrisgervang Aug 30, 2026
aef117f
Merge remote-tracking branch 'origin/master' into codex/path-style-of…
chrisgervang Aug 30, 2026
c45ab3a
Merge branch 'codex/path-style-offset-uniforms' into claude/deck-gl-p…
chrisgervang Aug 30, 2026
6ba316f
Merge branch 'claude/deck-gl-path-dashing-2jnq8i' into claude/deck-gl…
chrisgervang Aug 30, 2026
67122cb
Merge branch 'claude/deck-gl-path-dashing-2jnq8i-2' into claude/deck-…
chrisgervang Aug 30, 2026
8db6b19
Merge branch 'claude/deck-gl-path-dashing-2jnq8i-3' into claude/deck-…
chrisgervang Aug 30, 2026
ae0924f
fix(path-layer): preserve dash phase through camera clipping
chrisgervang Aug 30, 2026
3bf7fa7
Merge branch 'claude/deck-gl-path-dashing-2jnq8i-2' into claude/deck-…
chrisgervang Aug 30, 2026
5c0d54d
Merge branch 'claude/deck-gl-path-dashing-2jnq8i-3' into claude/deck-…
chrisgervang Aug 30, 2026
65946eb
Merge remote-tracking branch 'origin/master' into claude/deck-gl-path…
chrisgervang Aug 30, 2026
4ed7904
Merge branch 'claude/deck-gl-path-dashing-2jnq8i' into claude/deck-gl…
chrisgervang Aug 30, 2026
ad7da78
Merge branch 'claude/deck-gl-path-dashing-2jnq8i-2' into claude/deck-…
chrisgervang Aug 30, 2026
07c37c6
Merge branch 'claude/deck-gl-path-dashing-2jnq8i-3' into claude/deck-…
chrisgervang Aug 30, 2026
d20689e
fix(core): compare viewport projection state in equals
chrisgervang Aug 30, 2026
92c3fb8
Merge viewport equality prerequisite into path style benchmarks
chrisgervang Aug 30, 2026
fc3e94d
Merge updated PathStyle benchmark parent
chrisgervang Aug 30, 2026
1082e54
Merge updated dash arclength parent
chrisgervang Aug 30, 2026
1a7a565
Merge updated analytic coverage parent
chrisgervang Aug 30, 2026
b72c6dd
fix(core): compare legacy meter projection in viewport equality
chrisgervang Aug 30, 2026
d4cccd7
Merge updated viewport equality prerequisite
chrisgervang Aug 30, 2026
57e7ed8
Merge updated PathStyle benchmark parent
chrisgervang Aug 30, 2026
d64d4f7
Merge updated dash arclength parent
chrisgervang Aug 30, 2026
340c63f
Merge updated analytic coverage parent
chrisgervang Aug 30, 2026
37553aa
refactor(core): keep legacy meter state private
chrisgervang Aug 30, 2026
09ccc6d
Merge updated viewport equality prerequisite
chrisgervang Aug 30, 2026
ab8e95c
Merge updated PathStyle benchmark parent
chrisgervang Aug 30, 2026
68b5b4b
Merge updated dash arclength parent
chrisgervang Aug 30, 2026
7d0b772
Merge updated analytic coverage parent
chrisgervang Aug 30, 2026
c52527a
refactor(core): keep Web Mercator equality local
chrisgervang Aug 30, 2026
e6a11e9
Merge updated viewport equality prerequisite
chrisgervang Aug 30, 2026
0888ac0
Merge updated PathStyle benchmark parent
chrisgervang Aug 30, 2026
e595c4a
Merge updated dash arclength parent
chrisgervang Aug 30, 2026
370c85d
Merge updated analytic coverage parent
chrisgervang Aug 30, 2026
8fd8b20
Merge master after viewport equality prerequisite
chrisgervang Aug 30, 2026
92d1df8
Merge updated PathStyle benchmark parent
chrisgervang Aug 30, 2026
cee171c
Merge updated dash arclength parent
chrisgervang Aug 30, 2026
c144bfa
Merge updated analytic dash coverage parent
chrisgervang Aug 30, 2026
26ff678
Merge master after PathStyle render matrix
chrisgervang Aug 31, 2026
cacca9c
test(render): remove resolved dash baseline notes
chrisgervang Aug 31, 2026
67fac11
fix(extensions): make PathStyle options optional
chrisgervang Aug 31, 2026
a2f8364
Merge remote-tracking branch 'origin/master' into codex/path-style-op…
chrisgervang Aug 31, 2026
cedc874
Merge optional PathStyle options prerequisite
chrisgervang Aug 31, 2026
4e16165
Merge updated PathStyle arclength parent
chrisgervang Aug 31, 2026
45935ab
fix(extensions): scope rounded corner coverage to offsets
chrisgervang Aug 31, 2026
a15707c
Merge updated analytic coverage parent
chrisgervang Aug 31, 2026
b711094
docs(extensions): clarify high-precision dash deprecation
chrisgervang Aug 31, 2026
3f13102
test(extensions): keep dash mode coverage feature-scoped
chrisgervang Aug 31, 2026
89f415d
fix(extensions): type the offset shader variant
chrisgervang Aug 31, 2026
7e1e80b
Merge typed offset shader variant
chrisgervang Aug 31, 2026
1a022ca
Merge current master
chrisgervang Aug 31, 2026
a4d762a
Merge current options prerequisite
chrisgervang Aug 31, 2026
52d86fa
Merge current PathStyle parent
chrisgervang Aug 31, 2026
c51c744
Merge current PathStyle parent
chrisgervang Aug 31, 2026
b0f0101
Merge branch 'master' into claude/deck-gl-path-dashing-2jnq8i-2
chrisgervang Aug 31, 2026
659d30f
Merge current master
chrisgervang Aug 31, 2026
85f58ab
fix(path-layer): preserve clipped dash joint bounds
chrisgervang Aug 31, 2026
c38672a
refactor(extensions): clarify dash metric invalidation
chrisgervang Aug 31, 2026
bdf94da
Merge updated dash metric layer
chrisgervang Aug 31, 2026
6a346a5
Merge updated analytic dash coverage
chrisgervang Aug 31, 2026
50f3053
fix(extensions): rescale offset dash bounds
chrisgervang Aug 31, 2026
db34f4c
Merge offset dash bounds fix
chrisgervang Aug 31, 2026
1b9eb77
Merge offset dash bounds fix
chrisgervang Aug 31, 2026
d8905ee
test(render): baseline clipped PathStyle composition
chrisgervang Aug 31, 2026
d7dec88
Merge clipped PathStyle render baseline
chrisgervang Aug 31, 2026
1239863
test(render): capture clipped dash arclength fixes
chrisgervang Aug 31, 2026
9296f4c
Merge clipped PathStyle arclength baseline
chrisgervang Aug 31, 2026
455fb3b
test(render): capture clipped dash analytic coverage
chrisgervang Aug 31, 2026
dd15b26
Merge clipped PathStyle analytic baseline
chrisgervang Aug 31, 2026
088844b
Merge clipped PathStyle render prerequisite
chrisgervang Aug 31, 2026
181c3d0
Merge clipped PathStyle render prerequisite
chrisgervang Aug 31, 2026
50915ef
Merge clipped PathStyle render prerequisite
chrisgervang Aug 31, 2026
5c51ecc
test(render): document PathStyle dash expectations
chrisgervang Aug 31, 2026
3f583e7
Merge updated PathStyle arclength parent
chrisgervang Aug 31, 2026
9769819
Merge updated analytic coverage parent
chrisgervang Aug 31, 2026
c778a17
Merge #10581 from master
chrisgervang Sep 2, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions modules/extensions/src/path-style/shaders.glsl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -460,9 +460,10 @@ in float instanceOffsets;
vPathLength *= offsetWidth;
#ifdef DASH_ENABLED
// DECKGL_FILTER_SIZE above widened the stroke by offsetWidth, so the three rescalings
// here restore units of the original half-width. vDashOffset was computed against the
// widened stroke in the dash block, which merges ahead of this one, so it needs the same
// correction or a dashed offset line drifts out of phase with an unoffset one.
// above and the two below restore units of the original half-width. vDashOffset was computed
// against the widened stroke in the dash block, which merges ahead of this one, so it needs
// the same correction or a dashed offset line drifts out of phase with an unoffset one.
vPathBounds *= offsetWidth;
vDashOffset *= offsetWidth;
#endif
`,
Expand Down
9 changes: 9 additions & 0 deletions test/modules/extensions/path.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import {device, getLayerUniforms, testLayer} from '@deck.gl/test-utils/vitest';
import {vec3} from '@math.gl/core';

import * as FIXTURES from 'deck.gl-test/data';
import {offsetShaders} from '../../../modules/extensions/src/path-style/shaders.glsl';

const webglTest = device.type === 'webgl' ? test : test.skip;

Expand Down Expand Up @@ -517,6 +518,14 @@ test('PathStyleExtension#shader defines', () => {
testLayer({Layer: PathLayer, testCases, onError: err => expect(err).toBeFalsy()});
});

test('PathStyleExtension#offset keeps dash coordinates in the same units', () => {
const offsetVertexShader = offsetShaders.inject['vs:#main-end'];
expect(offsetVertexShader).toContain('vPathPosition.y *= offsetWidth');
expect(offsetVertexShader).toContain('vPathLength *= offsetWidth');
expect(offsetVertexShader).toContain('vPathBounds *= offsetWidth');
expect(offsetVertexShader).toContain('vDashOffset *= offsetWidth');
});

test('PathStyleExtension#getDashOffsets measures 3D distance', () => {
const extension = new PathStyleExtension({highPrecisionDash: true});
// The shader now scales its along-segment coordinate by the same 3D-to-2D arclength ratio,
Expand Down