Visitar URL original
HeatmapLayer: accept borrowed GPUVector inputs by ibgreen · Pull Request #11061 · visgl/deck.gl · GitHub
Skip to content

HeatmapLayer: accept borrowed GPUVector inputs - #11061

Merged
ibgreen merged 4 commits into
masterfrom
codex/heatmap-gpu-columns
Nov 9, 2026
Merged

ibgreen merged 4 commits into
masterfrom
codex/heatmap-gpu-columns

Conversation

@ibgreen

@ibgreen ibgreen commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Follow up of #11044.

Background

HeatmapLayer accepts accessor and binary inputs but cannot consume borrowed GPU columns directly. Add position and weight GPUVectors to its existing weight-texture path, preserving offsets and strides without readback.

Change List

  • Add borrowed positions and single-channel weights columns
  • Support row prefixes and zero-row recovery
  • Bind explicit layouts and zero position-low storage
  • Unit tests
  • Documentation

CI passes: package build, lint, coverage, WebGPU tests, website, Python, and projection example. Initial scope: float32x3 positions, float32 weights, no extensions or CPU preprojection. Focused tests verify actual buffer bindings, offsets, strides, and borrowed ownership.


Note

Low Risk
Low risk as this introduces an opt-in GPU vector path on WebGPU without modifying the default accessor and attribute pipelines.

Overview
Adds support for borrowed positions and weights GPUVector props in HeatmapLayer when running on WebGPU. This allows callers to bypass CPU accessors and supply pre-allocated GPU column buffers directly while preserving byte offsets and strides.

The layer derives instance counts from vector lengths or numInstances prefixes, configuring explicit buffer layouts and managing zeroed low-precision position buffers for weight-transform aggregation. When GPU vector props are omitted, standard attribute updates and accessor pathways remain unchanged.

Reviewed by Cursor Bugbot for commit b5f04dc. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable issues were found.

Summary

HeatmapLayer accepts borrowed position and weight GPUVector inputs on WebGPU.

  • HeatmapLayer can read borrowed GPU columns on WebGPU.

Reviews (6) · Last reviewed commit: "Document Heatmap GPU columns with the la..." · Reviewed by Greptile

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c5d050b. Configure here.

@coveralls

coveralls commented Nov 7, 2026 •

Copy link
Copy Markdown

Coverage Status

coverage: 84.232% (-0.07%) from 84.3% — codex/heatmap-gpu-columns into master

@ibgreen
ibgreen force-pushed the codex/heatmap-gpu-columns branch from 5de152e to aa9e274 Compare November 7, 2026 19:28
@ibgreen
ibgreen force-pushed the codex/heatmap-gpu-columns branch from aa9e274 to 6ab4985 Compare November 8, 2026 13:29
@ibgreen
ibgreen merged commit b5051af into master Nov 9, 2026
9 checks passed
@ibgreen
ibgreen deleted the codex/heatmap-gpu-columns branch November 9, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants