Visitar URL original
HexagonLayer: add WebGPU aggregation with explicit domains by ibgreen · Pull Request #11062 · visgl/deck.gl · GitHub
Skip to content

HexagonLayer: add WebGPU aggregation with explicit domains - #11062

Merged
ibgreen merged 28 commits into
masterfrom
codex/webgpu-hexagon
Nov 9, 2026
Merged

ibgreen merged 28 commits into
masterfrom
codex/webgpu-hexagon

Conversation

@ibgreen

@ibgreen ibgreen commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Follow up of #11053.

Background

HexagonLayer uses CPU aggregation on WebGPU. Add compute binning with independent color and elevation channels and explicit domains.

Change List

  • Add hexagonal bin assignment to the shared reducer
  • Preserve CPU fallbacks and device-buffer limit checks
  • Feed GPU results directly to the cell layer
  • Hide empty cells with a WGSL-safe NaN check
  • Preserve integer-weight fallback across prop-only updates
  • Unit tests
  • Documentation

Refreshed against master after #11018/#11019. Build, lint, nine Hexagon tests, 119 Node tests and two WebGPU golden comparisons pass; final CI is green, including coverage, WebGPU and website checks. Picking, extensions and automatic domains remain follow-ups.

@greptile-apps

greptile-apps Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues remain.

Summary

Adds WebGPU aggregation to HexagonLayer when both domains are supplied.

  • HexagonLayer aggregates supported data with WebGPU compute.

The four earlier, unnumbered findings are addressed in the current code. No new actionable issues were found. Tests were not run during this review.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[HexagonLayer inputs] --> B{Compute configuration supported?}
  B -->|No| C[CPU aggregation]
  B -->|Yes| D{Inputs and bins fit device limits?}
  D -->|Yes| E[WebGPUHexagonAggregator]
  D -->|No: accessor data| C
  D -->|No: GPU-only columns| F[Reject configuration]
  E --> G[Separate color and elevation results]
  G --> H[HexagonCellLayer]
  C --> H
Loading

Reviews (12) · Last reviewed commit: "test(aggregation-layers): retain integer..." · Reviewed by Greptile

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ab55c48. Configure here.

@coveralls

coveralls commented Nov 7, 2026 •

Copy link
Copy Markdown

Coverage Status

coverage: 83.673% (-0.1%) from 83.8% — codex/webgpu-hexagon into master

@ibgreen
ibgreen force-pushed the codex/webgpu-hexagon branch 3 times, most recently from 92709a4 to 4821893 Compare November 7, 2026 19:10
@ibgreen
ibgreen force-pushed the codex/webgpu-hexagon branch from 4821893 to d5b3af7 Compare November 7, 2026 19:25
@ibgreen
ibgreen force-pushed the codex/webgpu-hexagon branch 2 times, most recently from 558c96c to 5036217 Compare November 8, 2026 13:20
Base automatically changed from codex/webgpu-grid to master November 8, 2026 13:28
@ibgreen
ibgreen force-pushed the codex/webgpu-hexagon branch from 5036217 to 0bf7c8e Compare November 8, 2026 13:29
@ibgreen
ibgreen merged commit e6dc89c into master Nov 9, 2026
9 checks passed
@ibgreen
ibgreen deleted the codex/webgpu-hexagon branch November 9, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants