Visitar URL original
Close Resync, Audit and Check-This-Repo Procedure Gaps by ptr727 · Pull Request #4133 · ptr727/ProjectTemplate · GitHub
Skip to content

Close Resync, Audit and Check-This-Repo Procedure Gaps - #4133

Merged
ptr727 merged 6 commits into
developfrom
burndown/resync-audit-procedures
Nov 13, 2026
Merged

ptr727 merged 6 commits into
developfrom
burndown/resync-audit-procedures

Conversation

@ptr727

@ptr727 ptr727 commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Summary

Closes on promotion: #4098, #4014

Local Review Findings Disposed After the Opening Push

The third local pass left three introduced findings open at the opening push. The next push disposes of each.

  • Fixed: check-this-repo names the refspec git fetch origin "+refs/heads/<live.branch>:refs/remotes/origin/<live.branch>", so a single-branch hub clone records origin/<live.branch>.
  • Fixed: RESYNC.md section 0 runs its routing measurement after section 1's host gate, as resync-a-repo does.
  • Declined: reading run.tree in place of the two contents reads in check_dependabot_ecosystems. The github-actions arm beside it reads the contents API the same way, and run.tree is None for a truncated tree, so the change needs a fallback branch for no correctness gain in a file near its line ceiling.

A fourth pass found no test for the .devcontainer/ directory arm, now covered by a directory-only case in tests/test_audit.py.

Verification

  • tests/test_audit.py: new whole-run cases report the missing ecosystem for a tree holding only .devcontainer.json, and for one holding only a .devcontainer/ directory, with a clean control. The first fails against the unfixed spec/audit.py, and the second fails with .devcontainer dropped from the loop.
  • tests/test_release_guards.py: the AUDIT.md probe test gains a root-file fixture that must print devcontainers: MISSING. It fails against the unfixed AUDIT.md.
  • tests/test_audit_helpers.py, tests/test_release_guards.py, spec/audit.py --selftest, spec/validate.py, and scripts/build_dist.py --check pass. The pre-commit gates pass.

🤖 Generated with Claude Code

ptr727 and others added 3 commits November 12, 2026 21:27
State the develop exception for a registry entry not yet promoted in
RESYNC.md section 1 and step 5, and in the resync-a-repo skill, as
GOVERNANCE.md "Hub-Hosted Tooling" already does.

Name the RepoName on both audit-a-repo audit commands, keep a local
section in place inside an intent-fidelity carried file, gate the host
before resync-a-repo's first audit, and have check-this-repo compare a
git live.commit with the fetched hub revision.

Treat a root .devcontainer.json as implying the devcontainers
Dependabot ecosystem in spec/audit.py, AUDIT.md section 6 and its
probe, and spec/project-types.json, with a test for each.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Keep a local section in place only where the carried file is itself
its destination, gate the host after the worktrees exist and before
the first audit, and state how check-this-repo tests a git live.commit
against the hub's tip of its branch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Name CODESTYLE.md as the one guarded file a local section stays in,
require full hub history for check-this-repo's behind test and report
an exit other than 0 or 1, and stop resync-a-repo re-running an audit
its own first step already ran after the host gate.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings November 13, 2026 05:39
@ptr727

ptr727 commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 54238daccd653eb468307db6f2d5604315dc2b73, the content this pull request carries at that commit against develop, and it recorded 3 findings.

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 42 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between fa06887 and e311093.

Files ignored due to path filters: 12

  • .claude-plugin/fleet-skills/.source-digests/audit-a-repo is excluded by !.claude-plugin/fleet-skills/**
  • .claude-plugin/fleet-skills/.source-digests/carried-instruction-file-guard is excluded by !.claude-plugin/fleet-skills/**
  • .claude-plugin/fleet-skills/.source-digests/check-this-repo is excluded by !.claude-plugin/fleet-skills/**
  • .claude-plugin/fleet-skills/.source-digests/resync-a-repo is excluded by !.claude-plugin/fleet-skills/**
  • .claude-plugin/fleet-skills/skills/audit-a-repo/SKILL.md is excluded by !.claude-plugin/fleet-skills/**
  • .claude-plugin/fleet-skills/skills/carried-instruction-file-guard/SKILL.md is excluded by !.claude-plugin/fleet-skills/**
  • .claude-plugin/fleet-skills/skills/check-this-repo/SKILL.md is excluded by !.claude-plugin/fleet-skills/**
  • .claude-plugin/fleet-skills/skills/resync-a-repo/SKILL.md is excluded by !.claude-plugin/fleet-skills/**
  • .github/skills/audit-a-repo/SKILL.md is excluded by !.github/skills/**
  • .github/skills/carried-instruction-file-guard/SKILL.md is excluded by !.github/skills/**
  • .github/skills/check-this-repo/SKILL.md is excluded by !.github/skills/**
  • .github/skills/resync-a-repo/SKILL.md is excluded by !.github/skills/**
Files selected for processing: 10

  • .agents/skills/audit-a-repo/SKILL.md
  • .agents/skills/carried-instruction-file-guard/SKILL.md
  • .agents/skills/check-this-repo/SKILL.md
  • .agents/skills/resync-a-repo/SKILL.md
  • AUDIT.md
  • RESYNC.md
  • spec/audit.py
  • spec/project-types.json
  • tests/test_audit.py
  • tests/test_release_guards.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Give check-this-repo the refspec that records origin/<live.branch> in a
single-branch hub clone, and run RESYNC.md section 0's routing audit
after section 1's host gate, as the resync-a-repo skill now does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Several active documentation and audit-efficiency issues remain unresolved, including inconsistent host-gate ordering, incomplete remote-branch fetching guidance, and redundant API calls.

4 open issues
What changed in this PR

This PR closes procedure and audit gaps in the fleet's resync, audit, and repository self-check workflows. It updates canonical skills and generated distributions, extends devcontainer detection, and adds regression coverage.

Changes:

  • Documents the develop hub exception and aligns host-gate ordering in resync guidance.
  • Improves targeted auditing, carried-file merging, stale checkout detection, and root .devcontainer.json handling.
  • Updates tests, generated Skills, and source digests; three review findings remain open.
File Description
tests/​test_release_guards.py Adds probe coverage for detecting a root .devcontainer.json file.
tests/​test_audit.py Adds whole-run coverage for requiring the devcontainers ecosystem when a root devcontainer file is present.
spec/​project-types.json Updates the Dependabot ecosystem assertion for root devcontainer files.
spec/​audit.py Detects .devcontainer/ paths and root .devcontainer.json files during ecosystem auditing.
RESYNC.md Documents the unpromoted develop hub-checkout exception and related resync procedure guidance.
AUDIT.md Updates Dependabot coverage documentation and its root devcontainer probe.
.github/​skills/​resync-a-repo/​SKILL.md Updates distributed resync guidance for host gating and hub branch selection.
.github/​skills/​check-this-repo/​SKILL.md Adds guidance for detecting stale live Git checkouts.
.github/​skills/​carried-instruction-file-guard/​SKILL.md Clarifies preservation of local sections in carried instruction files.
.github/​skills/​audit-a-repo/​SKILL.md Adds repository names to targeted audit commands.
.claude-plugin/​fleet-skills/​skills/​resync-a-repo/​SKILL.md Updates the generated Claude resync Skill distribution.
.claude-plugin/​fleet-skills/​skills/​check-this-repo/​SKILL.md Updates the generated Claude repository-check Skill distribution.
.claude-plugin/​fleet-skills/​skills/​carried-instruction-file-guard/​SKILL.md Updates the generated Claude carried-file guard Skill distribution.
.claude-plugin/​fleet-skills/​skills/​audit-a-repo/​SKILL.md Updates the generated Claude audit Skill distribution.
.claude-plugin/​fleet-skills/​.source-digests/​resync-a-repo Refreshes the source digest for the resync Skill.
.claude-plugin/​fleet-skills/​.source-digests/​check-this-repo Refreshes the source digest for the repository-check Skill.
.claude-plugin/​fleet-skills/​.source-digests/​carried-instruction-file-guard Refreshes the source digest for the carried-file guard Skill.
.claude-plugin/​fleet-skills/​.source-digests/​audit-a-repo Refreshes the source digest for the audit Skill.
.agents/​skills/​resync-a-repo/​SKILL.md Updates the canonical resync procedure with hub branch and host-gate guidance.
.agents/​skills/​check-this-repo/​SKILL.md Adds canonical guidance for validating live checkout ancestry.
.agents/​skills/​carried-instruction-file-guard/​SKILL.md Adds canonical guidance for preserving local destination-file sections.
.agents/​skills/​audit-a-repo/​SKILL.md Adds canonical repository-specific audit command guidance.

Review effort: Lite

Comment thread .agents/skills/check-this-repo/SKILL.md Resolved
Comment thread .agents/skills/resync-a-repo/SKILL.md Resolved
Comment thread RESYNC.md Resolved
Comment thread spec/audit.py Resolved
ptr727 and others added 2 commits November 12, 2026 21:44
Answer a contents read of a directory in the test_audit.py fake, and
pin that a .devcontainer/ directory alone still draws the devcontainers
finding, so dropping it from the loop fails a test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Answer a directory read with its direct children by name, fix the
control test's docstring, and keep resync-a-repo's re-run before acting
on an earlier audit finding.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.70%. Comparing base (fa06887) to head (e311093).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4133      +/-   ##
===========================================
+ Coverage    76.69%   76.70%   +0.01%     
===========================================
  Files           40       40              
  Lines        14146    14148       +2     
===========================================
+ Hits         10849    10852       +3     
+ Misses        3297     3296       -1     
Flag Coverage Δ
python-3.13 76.70% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727

ptr727 commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head e311093b02162072c8a299f94090ed9cd8d9522c, the content this pull request carries at that commit against develop, and it recorded 1 finding.

@ptr727

ptr727 commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@ptr727

ptr727 commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

/review

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ptr727
ptr727 merged commit d5e2b58 into develop Nov 13, 2026
13 checks passed
@ptr727
ptr727 deleted the burndown/resync-audit-procedures branch November 13, 2026 06:37
ptr727 added a commit that referenced this pull request Nov 13, 2026
Names the two gaps from #4117 as hand checks in RESYNC.md section 5: a
caller workflow pin behind the newest hub release, and a missing
`hub_fetch_run.py` or a hook config that does not call it. Whether
`spec/audit.py` should check the pin mechanically is decision #4137 and
is not implemented here. The hook-helper half stays a hand check because
GOVERNANCE.md says `parity.hooks` is never mechanized by
`spec/audit.py`.

Also fixes a disagreement #4133 left: the RESYNC.md flowchart labelled
step 1 "fetch hub main" without the develop exception #4133 added to the
section 1 prose. The label now carries it.

Closes on promotion: #4117

Local review: the findings raised by the passes and by hosted review
were fixed; the last recorded pass found nothing.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
ptr727 added a commit that referenced this pull request Nov 13, 2026
… Rules (#4189)

## Summary

Promotes the backlog-burndown rounds and changes from other hub sessions
from `develop` to `main`.

- Hooks and the prose gate: #4132, #4134, #4136, #4145, #4152, #4184.
The Husky hook reads its path list once and diffs a merge against
`MERGE_HEAD`. Interrupts re-raise their signal, a Markdown code span
reads as quoted data, and the gate picks a commit's diff base and
recognizes a conflicted promotion's branch cut from `main`.
- Procedures and carried rules: #4133, #4139, #4141, #4149, #4166,
#4177, #4179, #4183, #4185. Resync, audit and check-this-repo procedure
gaps, code style and shell interrupt rules, review-loop gaps across four
skills, the context and delegation section of `AGENTS.md`, question
rules in governance, the promotion line in pull request bodies,
closing-keyword behavior on promotion, and the history-rewrite premise.
- Review and cleanup tooling: #4138, #4148, #4154, #4156, #4157, #4163,
#4164, #4168, #4174, #4180. Cleanliness reads, parked handoffs, the
backlog report's JSON output, exact inline script pins, trusted inputs,
env-file includes, the bounded review wait, side-reviewer matching, and
a Copilot billing-failure notice read as a refusal.
- Workflow and runbook contract: #4153, #4155, #4169, #4171, #4178,
#4182. The runtime-secrets check, a registry entry and spec references,
the Copilot runbook pointers, credential-free checkout steps, and the
deploy-key and runner wording.
- From other hub sessions: #4159 (a repository's own .NET line under a
fleet default), #4161 (the 1Password CLI as an optional host tool),
#4162 (Codex's Windows installer and one managed opencode copy). These
carry no promotion line.

#4182 carries no promotion line by design, and #4175 holds the split-out
part of #4057's scope. Both #1448 and #4175 stay open.

Fixes #1071
Fixes #1154
Fixes #1391
Fixes #1471
Fixes #1594
Fixes #1620
Fixes #1627
Fixes #1650
Fixes #1801
Fixes #2853
Fixes #3620
Fixes #3668
Fixes #3697
Fixes #3766
Fixes #3787
Fixes #3837
Fixes #3840
Fixes #3842
Fixes #3844
Fixes #3865
Fixes #3882
Fixes #3890
Fixes #3894
Fixes #3912
Fixes #3916
Fixes #3954
Fixes #4014
Fixes #4015
Fixes #4016
Fixes #4043
Fixes #4050
Fixes #4057
Fixes #4058
Fixes #4062
Fixes #4084
Fixes #4097
Fixes #4098
Fixes #4099
Fixes #4104
Fixes #4108
Fixes #4114
Fixes #4115
Fixes #4117
Fixes #4118
Fixes #4119
Fixes #4121
Fixes #4122
Fixes #4123
Fixes #4131
Fixes #4135
Fixes #4140
Fixes #4142
Fixes #4143
Fixes #4144
Fixes #4151

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants