Visitar URL original
Say the Organization Copilot Runner Wins and Qualify Deploy-Key Claims by ptr727 · Pull Request #4182 · ptr727/ProjectTemplate · GitHub
Skip to content

Say the Organization Copilot Runner Wins and Qualify Deploy-Key Claims - #4182

Merged
ptr727 merged 2 commits into
developfrom
burndown/runner-precedence-and-followups
Nov 13, 2026
Merged

ptr727 merged 2 commits into
developfrom
burndown/runner-precedence-and-followups

Conversation

@ptr727

@ptr727 ptr727 commented Nov 13, 2026

Copy link
Copy Markdown
Owner

Summary

Unfiled defects this run found

  • Deploy-key claims that Say Where the Deploy-Site Task Actually Requires the SSH Key #1801's rewording left behind. .github/workflows/deploy-site-task.yml had two comments that assumed the deploy environment always defines DEPLOY_SSH_PRIVATE_KEY. One said the job's own environment binding determines the real value. The other said an unset environment secret reaches the assert step as an empty string. GitHub documents that an environment secret takes precedence over a same-named repository secret, and that the caller must still pass the secret. So a caller mapping a non-empty repository secret, with no environment secret of that name, delivers that value. Both comments are deleted. In docs/reusable-workflows.md, the "Deploy-site." sentence is qualified to "for a secret the environment defines", matching WORKFLOW.md's hugo bullet. The secrets paragraph's "fails its run when one it needs is missing or empty" now reads "reaches its job empty", which the local review pass raised.
  • The merge row in AGENTS.md "Where the Rules Live". It routed only to Repository Boundaries and Write Safety. The irreversible-step rule, merging included, also lives in GOVERNANCE.md "Communicating with the User", so the row now names that section too.

Verification

  • scripts/build_dist.py --check reports the generated skill distributions current, so no include region reads the changed text.
  • The pre-commit gate passed on each commit.
  • A local strict review pass is recorded for the pushed head. Round 1 raised one finding, the docs/reusable-workflows.md secrets-paragraph claim, which is fixed. Round 2 raised none.

🤖 Generated with Claude Code

ptr727 and others added 2 commits November 13, 2026 13:39
Record that the organization Copilot runner type wins over a setup
step's runs-on while repository customization is disabled.

Drop the deploy-site-task comments that assumed the environment always
defines DEPLOY_SSH_PRIVATE_KEY, and qualify the matching sentence in
docs/reusable-workflows.md as WORKFLOW.md already does.

Route the merge row in AGENTS.md to Communicating with the User too,
where the irreversible-step rule now lives.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings November 13, 2026 21:44
@ptr727

ptr727 commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 45340e53efae7245a4f2bdcdc43675686b3872d0, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 10 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between cb15c14 and 45340e5.

Files selected for processing: 4

  • .github/workflows/deploy-site-task.yml
  • AGENTS.md
  • docs/homelab-runner-selection-plan.md
  • docs/reusable-workflows.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain, so the documented runner precedence, deploy-secret handling, and governance-routing changes are ready for approval.

No open issues 🎉

What changed in this PR

This PR clarifies Copilot runner precedence, deploy-site secret handling, and governance routing. The reusable-workflow documentation still describes DEPLOY_SSH_PRIVATE_KEY as environment-only and uses ambiguous wording about an empty secret, while the merge-rule mapping needs clearer authorization wording.

Changes:

  • Documents organization-level Copilot runner precedence when repository customization is disabled.
  • Removes misleading deploy-key comments and qualifies reusable-workflow secret guidance.
  • Routes merge authorization through both repository-boundary and user-communication governance.
File Description
docs/​reusable-workflows.md Updates deploy-site secret behavior and adoption guidance, including environment-secret precedence and empty-secret handling.
docs/​homelab-runner-selection-plan.md Documents organization-level Copilot runner precedence when repository customization is disabled.
AGENTS.md Extends the merge-related rules mapping to include user-communication governance guidance.
.github/​workflows/​deploy-site-task.yml Removes comments that incorrectly assume the environment always defines the deploy key.

Review effort: Lite

@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.71%. Comparing base (b38e084) to head (45340e5).
⚠️ Report is 207 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4182      +/-   ##
===========================================
- Coverage    81.60%   76.71%   -4.89%     
===========================================
  Files           26       41      +15     
  Lines         9070    14317    +5247     
===========================================
+ Hits          7402    10984    +3582     
- Misses        1668     3333    +1665     
Flag Coverage Δ
python-3.13 76.71% <ø> (-4.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727

ptr727 commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@ptr727

ptr727 commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

/review

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ptr727
ptr727 merged commit a3404b9 into develop Nov 13, 2026
15 checks passed
@ptr727
ptr727 deleted the burndown/runner-precedence-and-followups branch November 13, 2026 22:02
ptr727 added a commit that referenced this pull request Nov 13, 2026
… Rules (#4189)

## Summary

Promotes the backlog-burndown rounds and changes from other hub sessions
from `develop` to `main`.

- Hooks and the prose gate: #4132, #4134, #4136, #4145, #4152, #4184.
The Husky hook reads its path list once and diffs a merge against
`MERGE_HEAD`. Interrupts re-raise their signal, a Markdown code span
reads as quoted data, and the gate picks a commit's diff base and
recognizes a conflicted promotion's branch cut from `main`.
- Procedures and carried rules: #4133, #4139, #4141, #4149, #4166,
#4177, #4179, #4183, #4185. Resync, audit and check-this-repo procedure
gaps, code style and shell interrupt rules, review-loop gaps across four
skills, the context and delegation section of `AGENTS.md`, question
rules in governance, the promotion line in pull request bodies,
closing-keyword behavior on promotion, and the history-rewrite premise.
- Review and cleanup tooling: #4138, #4148, #4154, #4156, #4157, #4163,
#4164, #4168, #4174, #4180. Cleanliness reads, parked handoffs, the
backlog report's JSON output, exact inline script pins, trusted inputs,
env-file includes, the bounded review wait, side-reviewer matching, and
a Copilot billing-failure notice read as a refusal.
- Workflow and runbook contract: #4153, #4155, #4169, #4171, #4178,
#4182. The runtime-secrets check, a registry entry and spec references,
the Copilot runbook pointers, credential-free checkout steps, and the
deploy-key and runner wording.
- From other hub sessions: #4159 (a repository's own .NET line under a
fleet default), #4161 (the 1Password CLI as an optional host tool),
#4162 (Codex's Windows installer and one managed opencode copy). These
carry no promotion line.

#4182 carries no promotion line by design, and #4175 holds the split-out
part of #4057's scope. Both #1448 and #4175 stay open.

Fixes #1071
Fixes #1154
Fixes #1391
Fixes #1471
Fixes #1594
Fixes #1620
Fixes #1627
Fixes #1650
Fixes #1801
Fixes #2853
Fixes #3620
Fixes #3668
Fixes #3697
Fixes #3766
Fixes #3787
Fixes #3837
Fixes #3840
Fixes #3842
Fixes #3844
Fixes #3865
Fixes #3882
Fixes #3890
Fixes #3894
Fixes #3912
Fixes #3916
Fixes #3954
Fixes #4014
Fixes #4015
Fixes #4016
Fixes #4043
Fixes #4050
Fixes #4057
Fixes #4058
Fixes #4062
Fixes #4084
Fixes #4097
Fixes #4098
Fixes #4099
Fixes #4104
Fixes #4108
Fixes #4114
Fixes #4115
Fixes #4117
Fixes #4118
Fixes #4119
Fixes #4121
Fixes #4122
Fixes #4123
Fixes #4131
Fixes #4135
Fixes #4140
Fixes #4142
Fixes #4143
Fixes #4144
Fixes #4151

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants