Visitar URL original
Close Five Review Gaps in repo-worktree, drive-pr, pr-review-conduct, and backlog-burndown by ptr727 · Pull Request #4166 · ptr727/ProjectTemplate · GitHub
Skip to content

Close Five Review Gaps in repo-worktree, drive-pr, pr-review-conduct, and backlog-burndown - #4166

Merged
ptr727 merged 12 commits into
developfrom
burndown/skill-review-gaps
Nov 13, 2026
Merged

ptr727 merged 12 commits into
developfrom
burndown/skill-review-gaps

Conversation

@ptr727

@ptr727 ptr727 commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Closes review gaps in four fleet skills, and gives the carried-table bound its reason in GOVERNANCE.md and the Copilot instructions.

Changes

Item Dispositions

Verification

  • scripts/build_dist.py --check reports the generated distributions current. spec/validate.py passes.
  • The prose gate and repo_gate.py --check eol are clean on every commit.
  • The hook check was run against a constructed repository. With no hook it exits 1, with a foreign executable 1, and with a framework-header hook 0. The header line was read from the pre-commit framework's own hook template on this host.

Closes on promotion: #3620, #3697, #3766

🤖 Generated with Claude Code

ptr727 and others added 3 commits November 13, 2026 10:01
… and backlog-burndown

- repo-worktree: a shared pre-commit hook counts only when it carries the
  framework's own header, and a missing one is asked through the prompt and
  installed once in the base clone on the maintainer's yes.
- drive-pr: open findings on a peer-merged feature PR still get an outcome.
- pr-review-conduct and copilot-instructions: say why the carried-table bound
  is the file set rather than file recency.
- backlog-burndown: a displaced group's fresh worker dispatches once the
  freeze lifts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…Kind After a Peer Merge

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…a Peer Merge

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings November 13, 2026 18:15
@ptr727

ptr727 commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head da1f61645126338b1b4ca355b8a895eaa8bd3f17, the content this pull request carries at that commit against develop, and it recorded 2 findings.

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 53 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between da917cd and a1058f2.

Files ignored due to path filters: 12

  • .claude-plugin/fleet-skills/.source-digests/backlog-burndown is excluded by !.claude-plugin/fleet-skills/**
  • .claude-plugin/fleet-skills/.source-digests/drive-pr is excluded by !.claude-plugin/fleet-skills/**
  • .claude-plugin/fleet-skills/.source-digests/pr-review-conduct is excluded by !.claude-plugin/fleet-skills/**
  • .claude-plugin/fleet-skills/.source-digests/repo-worktree is excluded by !.claude-plugin/fleet-skills/**
  • .claude-plugin/fleet-skills/skills/backlog-burndown/SKILL.md is excluded by !.claude-plugin/fleet-skills/**
  • .claude-plugin/fleet-skills/skills/drive-pr/SKILL.md is excluded by !.claude-plugin/fleet-skills/**
  • .claude-plugin/fleet-skills/skills/pr-review-conduct/SKILL.md is excluded by !.claude-plugin/fleet-skills/**
  • .claude-plugin/fleet-skills/skills/repo-worktree/SKILL.md is excluded by !.claude-plugin/fleet-skills/**
  • .github/skills/backlog-burndown/SKILL.md is excluded by !.github/skills/**
  • .github/skills/drive-pr/SKILL.md is excluded by !.github/skills/**
  • .github/skills/pr-review-conduct/SKILL.md is excluded by !.github/skills/**
  • .github/skills/repo-worktree/SKILL.md is excluded by !.github/skills/**
Files selected for processing: 6

  • .agents/skills/backlog-burndown/SKILL.md
  • .agents/skills/drive-pr/SKILL.md
  • .agents/skills/pr-review-conduct/SKILL.md
  • .agents/skills/repo-worktree/SKILL.md
  • .github/copilot-instructions.md
  • GOVERNANCE.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The maintainer-refusal path remains non-terminal, allowing setup attempts or continued work without the required gate, so the instructions must explicitly leave setup unresolved and stop the task.

1 open issue
What changed in this PR

This pull request closes documented review gaps across four fleet skills, updates the carried Copilot review guidance, and regenerates the GitHub Copilot and Claude Code distributions.

Changes:

  • Tightens pre-commit hook detection and documents maintainer-approved shared-hook installation.
  • Clarifies finding disposition after peer merges and delays displaced-worker dispatch until promotion freezes end.
  • Explains the file-set bound for carried review tables.
  • Regenerates derived skill copies and source digests.
  • One actionable issue remains: the shared-hook procedure lacks a terminal outcome when the maintainer declines installation.
File Description
.github/​skills/​repo-worktree/​SKILL.md Generated Copilot copy of the pre-commit hook validation and shared-hook repair guidance.
.github/​skills/​pr-review-conduct/​SKILL.md Generated Copilot copy explaining the file-set bound for carried review tables.
.github/​skills/​drive-pr/​SKILL.md Generated Copilot copy requiring outcomes for findings on peer-merged feature PRs.
.github/​skills/​backlog-burndown/​SKILL.md Generated Copilot copy delaying displaced-worker dispatch until the promotion freeze lifts.
.github/​copilot-instructions.md Updates Copilot guidance explaining the carried review-table coverage bound.
.claude-plugin/​fleet-skills/​skills/​repo-worktree/​SKILL.md Generated Claude Code copy of the pre-commit hook validation and shared-hook repair guidance.
.claude-plugin/​fleet-skills/​skills/​pr-review-conduct/​SKILL.md Generated Claude Code copy explaining the file-set bound for carried review tables.
.claude-plugin/​fleet-skills/​skills/​drive-pr/​SKILL.md Generated Claude Code copy requiring outcomes for findings on peer-merged feature PRs.
.claude-plugin/​fleet-skills/​skills/​backlog-burndown/​SKILL.md Generated Claude Code copy delaying displaced-worker dispatch until the promotion freeze lifts.
.claude-plugin/​fleet-skills/​.source-digests/​repo-worktree Records the regenerated source digest for the worktree skill.
.claude-plugin/​fleet-skills/​.source-digests/​pr-review-conduct Records the regenerated source digest for the review-conduct skill.
.claude-plugin/​fleet-skills/​.source-digests/​drive-pr Records the regenerated source digest for the drive skill.
.claude-plugin/​fleet-skills/​.source-digests/​backlog-burndown Records the regenerated source digest for the backlog-burndown skill.
.agents/​skills/​repo-worktree/​SKILL.md Updates canonical pre-commit hook validation and shared-hook repair authorization, but does not define a terminal outcome when the maintainer refuses installation.
.agents/​skills/​pr-review-conduct/​SKILL.md Explains why carried review tables use a file-set rather than file-recency bound.
.agents/​skills/​drive-pr/​SKILL.md Requires disposition outcomes for findings on feature PRs merged by peers.
.agents/​skills/​backlog-burndown/​SKILL.md Defers displaced-worker dispatch until the promotion freeze ends.

Review effort: Lite

Comment thread .agents/skills/repo-worktree/SKILL.md Resolved
ptr727 and others added 3 commits November 13, 2026 10:20
…r Merge Seen at Merge Time

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.75%. Comparing base (b38e084) to head (a1058f2).
⚠️ Report is 195 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4166      +/-   ##
===========================================
- Coverage    81.60%   76.75%   -4.86%     
===========================================
  Files           26       41      +15     
  Lines         9070    14279    +5209     
===========================================
+ Hits          7402    10960    +3558     
- Misses        1668     3319    +1651     
Flag Coverage Δ
python-3.13 76.75% <ø> (-4.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…s Before Cleanup

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ptr727

ptr727 commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 3dd0999f922fa8f04936a7c8e74b8bbf623a1071, the content this pull request carries at that commit against develop, and it recorded 3 findings.

ptr727 and others added 2 commits November 13, 2026 10:31
…, and Give Away Mode Its Re-dispatch Trigger

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…h to the Next Round

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ptr727

ptr727 commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 4e193d6aa2770eb3085269ee20956e26a4e6a539, the content this pull request carries at that commit against develop, and it recorded 3 findings.

ptr727 and others added 2 commits November 13, 2026 10:42
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ptr727

ptr727 commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head a1058f2f4f52238542071aa6cfbb70d98477c972, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@ptr727

ptr727 commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@ptr727

ptr727 commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

/review

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ptr727
ptr727 merged commit d9848bf into develop Nov 13, 2026
13 checks passed
@ptr727
ptr727 deleted the burndown/skill-review-gaps branch November 13, 2026 19:03
ptr727 added a commit that referenced this pull request Nov 13, 2026
… Rules (#4189)

## Summary

Promotes the backlog-burndown rounds and changes from other hub sessions
from `develop` to `main`.

- Hooks and the prose gate: #4132, #4134, #4136, #4145, #4152, #4184.
The Husky hook reads its path list once and diffs a merge against
`MERGE_HEAD`. Interrupts re-raise their signal, a Markdown code span
reads as quoted data, and the gate picks a commit's diff base and
recognizes a conflicted promotion's branch cut from `main`.
- Procedures and carried rules: #4133, #4139, #4141, #4149, #4166,
#4177, #4179, #4183, #4185. Resync, audit and check-this-repo procedure
gaps, code style and shell interrupt rules, review-loop gaps across four
skills, the context and delegation section of `AGENTS.md`, question
rules in governance, the promotion line in pull request bodies,
closing-keyword behavior on promotion, and the history-rewrite premise.
- Review and cleanup tooling: #4138, #4148, #4154, #4156, #4157, #4163,
#4164, #4168, #4174, #4180. Cleanliness reads, parked handoffs, the
backlog report's JSON output, exact inline script pins, trusted inputs,
env-file includes, the bounded review wait, side-reviewer matching, and
a Copilot billing-failure notice read as a refusal.
- Workflow and runbook contract: #4153, #4155, #4169, #4171, #4178,
#4182. The runtime-secrets check, a registry entry and spec references,
the Copilot runbook pointers, credential-free checkout steps, and the
deploy-key and runner wording.
- From other hub sessions: #4159 (a repository's own .NET line under a
fleet default), #4161 (the 1Password CLI as an optional host tool),
#4162 (Codex's Windows installer and one managed opencode copy). These
carry no promotion line.

#4182 carries no promotion line by design, and #4175 holds the split-out
part of #4057's scope. Both #1448 and #4175 stay open.

Fixes #1071
Fixes #1154
Fixes #1391
Fixes #1471
Fixes #1594
Fixes #1620
Fixes #1627
Fixes #1650
Fixes #1801
Fixes #2853
Fixes #3620
Fixes #3668
Fixes #3697
Fixes #3766
Fixes #3787
Fixes #3837
Fixes #3840
Fixes #3842
Fixes #3844
Fixes #3865
Fixes #3882
Fixes #3890
Fixes #3894
Fixes #3912
Fixes #3916
Fixes #3954
Fixes #4014
Fixes #4015
Fixes #4016
Fixes #4043
Fixes #4050
Fixes #4057
Fixes #4058
Fixes #4062
Fixes #4084
Fixes #4097
Fixes #4098
Fixes #4099
Fixes #4104
Fixes #4108
Fixes #4114
Fixes #4115
Fixes #4117
Fixes #4118
Fixes #4119
Fixes #4121
Fixes #4122
Fixes #4123
Fixes #4131
Fixes #4135
Fixes #4140
Fixes #4142
Fixes #4143
Fixes #4144
Fixes #4151

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants